pushbx wiki

This page is read only. You can view the source, but not change it. Ask your administrator if you think this is wrong.
====== Late February (+ early March) work on WarpLink ======

**2026-03-01**


===== WarpLink =====

  * Bugfix, [[https://hg.pushbx.org/ecm/warplink/rev/7f759534e2a0|read back the tempwllist structure after the innermost loop may have run]], to update it with twlListUsed set to twlUsedListItem.
  * Fix to [[https://hg.pushbx.org/ecm/warplink/rev/a76da95021d6|preserve the ?collectfunction across the call to the innermost loop]]. This bug took me more than 60 minutes to properly diagnose.
  * Fix [[https://hg.pushbx.org/ecm/warplink/rev/d665536102c6|repeated wllist entry crossing the boundary of a LEDATA block]]. The prior code assumed that the LEDATA boundary would always coincide with a tempwllist boundary, an oversight in the addition of repeated list items. The possibility of this bug occurred to me during a workday.
  * [[https://hg.pushbx.org/ecm/warplink/rev/a44f292e74c6|Increment ecm release]] to r14.
  * [[https://hg.pushbx.org/ecm/warplink/rev/fcc8692c711d|Fix a comment typo]], wrote "tmpwllist" instead of "tempwllist".
  * [[https://hg.pushbx.org/ecm/warplink/rev/9ae861e2a9c2|Split wllist errors]] into multiple error codes. Each one has a unique "problem" line while the "cause" and "solution" lines are shared across all of the wllist errors.
  * Similarly, [[https://hg.pushbx.org/ecm/warplink/rev/3e9f6e1294f3|add more wlcalc errors]], again with unique "problem" lines.
  * [[https://hg.pushbx.org/ecm/warplink/rev/5e3640b6d95a|Display internal error's error value as both hexadecimal and decimal]]. There were few errors above 9 so far, but the wlcalc and wllist internal errors I added all used decimal numbers in the sources.
  * [[https://hg.pushbx.org/ecm/warplink/rev/9ad6f9e17799|Comment on the GRP_ENT_STRUC structure]], and add a label to it (ges_flags). The comments include a bug: Two instructions both write to the same field of the structure, with different contents.
  * [[https://hg.pushbx.org/ecm/warplink/rev/440139f63cb4|Optimise branches to wlcalc errors]] by chaining several jumps, so that many of them can be short.
  * Allow wlcalc SEG operations [[https://hg.pushbx.org/ecm/warplink/rev/88dbf3356878|to match a group name instead]] of a segment name.
  * [[https://hg.pushbx.org/ecm/warplink/rev/2ac71530d3d1|Make the get_grpdef and get_segdef functions more consistent]] in their return values.
  * [[https://hg.pushbx.org/ecm/warplink/rev/6f11be45be87|Delete the unused INTERNAL_ERR_COUNT equate]].
  * Hack mlerror.nas [[https://hg.pushbx.org/ecm/warplink/rev/c35058a24d53|so it shows only a symbol for wlcalc errors]]. The problem that this was to solve was that the wrong filename would show up in the error messages, as the ''filename'' variable at this point held the last object's name, not necessarily that of the object in which the wlcalc request originated.
  * [[https://hg.pushbx.org/ecm/warplink/rev/a5f5f3729d88|Get the corresponding filename for wlcalc errors]]. This uses the file_mod_id field of the segment partiton ("spart") structure, then resets variables for and calls get_curr_obj repeatedly until the originating object filename is found.
  * [[https://hg.pushbx.org/ecm/warplink/rev/c9bb5bb0145b|Undo most of the second to last changeset]], so that wlcalc errors once again display a filename along with the offending symbol - now the correct filename.
  * [[https://hg.pushbx.org/ecm/warplink/rev/1f7ac5744a45|Add the twlObjIndex field to the tempwllist structure]], and use it to recover the correct object filename that originated a wllist label. This re-uses .get_object_filename of the wlcalc code, adding in three push and three pop instructions to preserve the variables used by get_curr_obj. (These variables need to be preserved if the error were to be handled as a warning, to allow the remainder of pass 1 and all of pass 2 to access the correct object files.)
  * Fix get_target_addr if a label isn't found, [[https://hg.pushbx.org/ecm/warplink/rev/b7b3aa247116|needs to pop es]].
  * [[https://hg.pushbx.org/ecm/warplink/rev/f5c6cdb88970|Add the WRT clause for EXT operations]]. To simplify parsing, WRT is treated as an operation that comes first, followed by a segment or group name, then followed by the actual operation - which must be one of the EXT-related operations. To allow underscores in WRT segment names, an '@' sign can be used which is followed by a quote mark byte (usually a second @).
  * [[https://hg.pushbx.org/ecm/warplink/rev/850406e01435|Add a proper error code for the quote mark byte being a NUL]] in a WRT clause.
  * Fix to [[https://hg.pushbx.org/ecm/warplink/rev/bb025888e4fb|copy the complete symbol name to name_field for every wlcalc error]]. This never does any harm, and fixes some cases that would incorrectly show a segment or extern name instead of the whole symbol name.
  * After the preparation done by the prior changeset, [[https://hg.pushbx.org/ecm/warplink/rev/bc85127a639f|no longer initially copy the wlcalc symbol name]] to the name_field. It wasn't ever used except to pass the symbol name to the error handler.
  * [[https://hg.pushbx.org/ecm/warplink/rev/3b71148db92b|Update protocol comments]] of the wlcalc get_segdef and get_grpdef functions.
  * [[https://hg.pushbx.org/ecm/warplink/rev/b858db142e29|Improve protocol comments]] for the extern fixup wlcalc functions.
  * [[https://hg.pushbx.org/ecm/warplink/rev/d9fa91f5fcb2|Add a single-line update]] missing in the prior changeset.
  * [[https://hg.pushbx.org/ecm/warplink/rev/1a8a74beb346|Change the extern fixup wlcalc functions to return an error code]] in ax (along with CY), to decouple them from the handle_wlcalc lframe context.
  * [[https://hg.pushbx.org/ecm/warplink/rev/6125f6a524fc|Increment ecm release]] to r15.
  * [[https://hg.pushbx.org/ecm/warplink/rev/90d440cfd4ce|Update ecm readme]] with WRT clause.
  * In ecm readme [[https://hg.pushbx.org/ecm/warplink/rev/a91720603477|mention that SEG operations can also operate on group names]].
  * [[https://hg.pushbx.org/ecm/warplink/rev/080b40e82edf|Fix the "total image size" in the .map file]] if the last section is empty.
  * [[https://hg.pushbx.org/ecm/warplink/rev/a85830d8e29a|Fix the image_size variable if the last section is empty]]. This undoes the prior changeset. An empty section would leave the segment_stop variable equal to the segment's start, ie the total size of the image at this point. But the code expected segment_stop + 1 to yield a size, assuming that segment_stop pointed **at** the last byte, not past it. All users of image_size seem to assume it holds a size, not size+1, so this patch addresses the root cause of this assumption being wrong.
  * [[https://hg.pushbx.org/ecm/warplink/rev/888831126908|Add the ITOA operation]], which formats a number into text. As yet the input and output buffers are the same size, limiting the range of permissible numbers. The numeric base (assumed as 2 <= base <= 36) is passed in the constant given to the ITOA operation.
  * [[https://hg.pushbx.org/ecm/warplink/rev/0e657d7b8791|Allow to enlarge the output buffer for ITOA]], to up to 10 bytes. This trades off the slightly larger stack frame in handle_wlcalc (for **all** wlcalc operations) for the simplicity of expanding the output buffer for ITOA. Buffer size is passed in ch (ie, the second-least significant byte of the constant value).
  * Add the ITOA [[https://hg.pushbx.org/ecm/warplink/rev/1c2231759aa8|flags for filling with zero digit text rather than blanks, and for shuffling the buffer]] so padding ends up at the end instead of the beginning. The shuffle operation was a little tricky to get right. First I reset bx within the innermost loop, causing it to run infinitely. Then I left the initial load of al in the innermost loop, overwriting everything with the padding. At some point I operated on the total buffer size rather than only the part populated according to ?size. Finally I had fixed the pointers but still counted down bx to the total buffer size (negative) rather than the used buffer size. I also found it difficult to track how the shuffling works, but the basic idea is sound.
  * [[https://hg.pushbx.org/ecm/warplink/rev/b83bcfea0d96|Explicitly check for ITOA bases 0 and 1]], which would result in a divide exception and an unbounded loop respectively (though the overflow detection should eventually bail you out of the loop when the buffer is full of zeroes).
  * [[https://hg.pushbx.org/ecm/warplink/rev/3cbb02158071|Document ITOA operation]] in the ecm readme.
  * [[https://hg.pushbx.org/ecm/warplink/rev/113a4ec92f3d|Increment ecm release]] to r16, and 2026 March, in mlcredit.nas and in the ecm readme.


**ETA** 2026-03-04:

  * [[https://hg.pushbx.org/ecm/warplink/rev/fff4e9b6d468|Fix a fairly harmless bug]]: zero_mem_image would write to a final word rather than a byte if given an odd length.
  * [[https://hg.pushbx.org/ecm/warplink/rev/d22a1ef760b5|Add the /TZ switch]] to force use of a temporary file.
  * [[https://hg.pushbx.org/ecm/warplink/rev/ef31bfe4c263|Fix cutting the 256-byte prefix with /TZ /C switches]]. This error could occur in the original WarpLink revision, but only if the setup_exe_image function (in mlimage1.nas) found more than 20 KiB of free DOS memory but below what would be needed to hold the entire executable image. (Note that the progbits image size used to be limited to <%%%%= 64 KiB minus the 256 Bytes prefix.)
  * [[https://hg.pushbx.org/ecm/warplink/rev/fb3750375c8a|Document the /TZ switch and the /TZ /C bugfix]] in ecm readme file.
  * [[https://hg.pushbx.org/ecm/warplink/rev/12dac100f452|Rework several file write loops, and add a check of the .COM prefix contents]]. The check generates a warning if the /C switch is used (without /CZ), and the first 256 bytes of the image are neither all-zeroes nor all NOP instructions (value 90h bytes).
  * [[https://hg.pushbx.org/ecm/warplink/rev/917d8abda86e|Document prefix warning]].
  * [[https://hg.pushbx.org/ecm/warplink/rev/f0d376302fe3|Increment ecm release]] to r17.
  * [[https://hg.pushbx.org/ecm/warplink/rev/cbf2e035a4c6|Add DOS error code -2]] for "short read", and set it when detecting a short read in several spots. This doesn't fix all possible cases of short reads as yet. As the custom "solution" text states, a short read is likely to be an internal error of the linker.
  * [[https://hg.pushbx.org/ecm/warplink/rev/102ebb9c2c0f|Add the /XCW switch]], treat /XC wlcalc "unknown" errors as warnings. This is useful to enumerate multiple wlcalc errors at once, rather than having to fix them one by one to discover the next one. The wlcalc overflow errors are unaffected. This also adds an /XLW switch for wllist, though this is less useful.
  * Fix [[https://hg.pushbx.org/ecm/warplink/rev/a6fbe3c9150f|to reset es]] after the _wlcalc_get_segdef_entry or _wlcalc_get_grpdef_entry functions. This seems to have caused some funny crashes. It now makes use of the fact that these functions leave ds =%%%%> DGROUP.
  * Fix: [[https://hg.pushbx.org/ecm/warplink/rev/69ef53184f54|Do not zero the file_mod_id field of segpart structures]]. I don't know why this should be cleared here. According to the comment next to it, it was "overwriting [the] unneeded file_mod_id". I don't know whether "unneeded" means this was merely to tidy up loose ends and not really needed (I hope!) or whether there is more of a reason why this should be done. In any case, it foiled my attempt to use the segpart structure's object index to get the correct object filename for wlcalc errors. I didn't notice the failure before working on lDebug's _LINK option because the clearing would set the field to zero, which is a valid object index and would appear to point to the first object file.
  * [[https://hg.pushbx.org/ecm/warplink/rev/f218093d183e|Document /XCW switch]] in the ecm readme file.
  * [[https://hg.pushbx.org/ecm/warplink/rev/71d7ff0063a8|Increment ecm release]] to r18.
  * [[https://hg.pushbx.org/ecm/warplink/rev/895b7f08cf17|Add optional digit groups with separators]] to the ITOA wlcalc operation. This adds a rare use of an "inner" lframe, which re-uses the bp as set up by the outer frame (actually a non-emitting copy of the handle_wlcalc lframe here). By using lpar and lpar_return, the minimum amount of instructions (exactly 1) is used to modify sp in the function. In this case, access to the outer lframe isn't needed, but using the inner frame is still advantageous as compared to using a "nested" lframe because it uses fewer setup instructions. Also in this case, the outer frame could be used as is to add more lvar variables -- but this is possible only once, whereas the inner lframe can be used for multiple functions with possibly different inner stack frames.
  * [[https://hg.pushbx.org/ecm/warplink/rev/598f411f822d|Document ITOA digit groups]] in the ecm readme.

{{tag>warplink lframe}}


~~DISCUSSION~~